Aaron Schulz [Thu, 11 Dec 2008 21:34:15 +0000 (21:34 +0000)]
Fix log list regression and fix funky $allLogs case while at it
Brion Vibber [Thu, 11 Dec 2008 21:12:11 +0000 (21:12 +0000)]
Make 'ChangePassword' be the default name form for the password change form instead of ResetPass.
Since it's something we're sending people to with an actual UI, for general password changing, and no longer specific to by-email password *resets*, it's nicer to use the cleaner name.
Raimond Spekking [Thu, 11 Dec 2008 20:13:24 +0000 (20:13 +0000)]
Consistency tweak: Add horizental line same as exists in Special:RecentChanges
Aaron Schulz [Thu, 11 Dec 2008 19:52:56 +0000 (19:52 +0000)]
Set focus
Alexandre Emsenhuber [Thu, 11 Dec 2008 19:11:11 +0000 (19:11 +0000)]
Fix encoding
Aaron Schulz [Thu, 11 Dec 2008 18:59:11 +0000 (18:59 +0000)]
*Disabled hit counter
*Added 'overwrite' option
Brion Vibber [Thu, 11 Dec 2008 18:44:51 +0000 (18:44 +0000)]
Reverting r44454 "(bug 14843) IRC should flag redirects with "R" like it does with bots, etc."
This doesn't work as intended; when editing existing articles, this'll pull the *previous* redirection state of the article, rather than the current state, so it's wrong whenever a page is changed into, or away from, being a redirect.
Brion Vibber [Thu, 11 Dec 2008 18:38:06 +0000 (18:38 +0000)]
Some more verbose output and fix infinite loop if you make the block size small :)
Chad Horohoe [Thu, 11 Dec 2008 17:42:49 +0000 (17:42 +0000)]
(bug 14843) IRC should flag redirects with "R" like it does with bots, etc.
Aaron Schulz [Thu, 11 Dec 2008 14:35:33 +0000 (14:35 +0000)]
Add a script to filecache content pages on the wiki
Aaron Schulz [Thu, 11 Dec 2008 14:29:16 +0000 (14:29 +0000)]
Pull up and tweak filecache check to make it much faster and able to for request to avoid a db hit if counters are off and job rate = 0
Alexandre Emsenhuber [Thu, 11 Dec 2008 11:50:45 +0000 (11:50 +0000)]
document SetupAfterCache hook ;)
Aaron Schulz [Thu, 11 Dec 2008 01:33:27 +0000 (01:33 +0000)]
Reduce queries for pagesize thingy
Aaron Schulz [Thu, 11 Dec 2008 01:28:37 +0000 (01:28 +0000)]
May as well set article ID in title
Aaron Schulz [Thu, 11 Dec 2008 01:17:17 +0000 (01:17 +0000)]
Fix this broken crap some more
Brion Vibber [Thu, 11 Dec 2008 00:54:21 +0000 (00:54 +0000)]
Revert r44381 "Remove noisy profiling"
We... like profiling? :D
Brion Vibber [Thu, 11 Dec 2008 00:42:50 +0000 (00:42 +0000)]
Revert r44365 "Cleanup Title::getTouched()"
Rather than a cleanup, this rev seems to be adding a per-Title-object cache of page_touched. I'm a little leery of adding extra caches like this, particularly since it's not clear that it'll get consistently updated.
Brion Vibber [Thu, 11 Dec 2008 00:29:37 +0000 (00:29 +0000)]
Revert r44335 "Tweak profile calls"
Let the doUpdates() func get counted even when it has nothing to do; otherwise stats will be skewed to only times when there are multiple updates. Or.... hmmm. bleah.
Brion Vibber [Wed, 10 Dec 2008 23:39:02 +0000 (23:39 +0000)]
Revert part of r44296 "*Skip autoloading of skin, always does inefficient strtolower() stuff and fails (returns false) anyway" and r44302 "Tweak r44296: use autoloader if it is set there".
Unless there's some really huge overriding reason to do this, there's no point poking around in the autoloader's guts to try to outsmart it. Just let it take a few nanoseconds to check its array and don't add yourself a dependency on its implementation details.
If there *is* some really huge overriding reason to complicate the code, please provide some data supporting it.
Brion Vibber [Wed, 10 Dec 2008 23:29:43 +0000 (23:29 +0000)]
Revert r44292 "Assign by ref to make sure cache fields carry over"
This isn't PHP 4; the object's fields are changed on the object itself just fine. Unless people are changing the global variable $wgTitle to something different this should be fine. If there is a problem that this fixes, that's probably a problem itself and should be fixed in a cleaner way :D
Aaron Schulz [Wed, 10 Dec 2008 23:27:25 +0000 (23:27 +0000)]
(bug 16589) CoreParserFunctions error causes 500
Brion Vibber [Wed, 10 Dec 2008 23:21:28 +0000 (23:21 +0000)]
Revert r44271 "(bug 12998) Weaken DISPLAYTITLE restictions (patch by 'rememberthedot@gmail.com')"
Behavior seems a bit hard to predict, as far as what's going to go in the header and what in the browser window etc. Pulling it back for further testing and discussion.
Andrew Garrett [Wed, 10 Dec 2008 23:15:50 +0000 (23:15 +0000)]
Configure extension: With DB handler, defer wfConfigureSetup() to a new hook, SetupAfterCache, which, as the name implies, is executed in Setup.php, after caches are initialised.
This avoids some weird issues with Configure and maintenance scripts.
Brion Vibber [Wed, 10 Dec 2008 23:06:44 +0000 (23:06 +0000)]
Revert r44257 "Use boolean searching with '?' char"
Let's avoid making up our own syntax that nobody will know or think to try...
Lucene, Google, Yahoo!, and Windows Live search all understand "red OR lion" but see nothing special in "?red ?lion". If we're going to add it, let's make the OR thing work. :)
Brion Vibber [Wed, 10 Dec 2008 22:58:24 +0000 (22:58 +0000)]
Revert r44254 "Cleanup to wfGetNull(): * Add override in case /dev/null isn't accessible (bug 11009)"
Doesn't seem like a proper fix here... At best, this'll be dumping random crap to some random file unless the user has a local copy of the /dev/null device file, which seems.... wrong. :)
For anything generating command lines, it probably won't make any difference (assuming exec() is enabled at all!) since open_basedir won't be searching through the command line (I think).
Assuming the core use case actually happens (open_basedir is set, but proc_open() is available to run tidy), a more correct fix is probably to go ahead and read in stderr and toss the results, or maybe better pass it through to PHP's stderr FD instead of opening /dev/null ourselves. Tidy has a -q option which should suppress random "hi i'm tidy version XYZ" if it's currently present.
Brion Vibber [Wed, 10 Dec 2008 22:41:13 +0000 (22:41 +0000)]
Attempting to import a title that came out as an interwiki would sort of half-work somewhere then explode when trying to save the null revision with the import info:
Fatal error: Call to a member function insertOn() on a non-object in /Library/WebServer/Documents/trunk/includes/specials/SpecialImport.php on line 305
Now such titles are skipped. You can probably force import of the page by forcing the target namespace...
Better long-term solution might include title renormalization, adapation of remote namespace names (eg Wikipedia -> Project), etc.
Roan Kattouw [Wed, 10 Dec 2008 22:39:41 +0000 (22:39 +0000)]
* API: (bug 16613) action=protect doesn't say when &cascade is set but cascading protection wasn't allowed
* Changed Article::updateRestrictions()'s $cascade parameter to a reference which is set to false if cascading protection isn't allowed
* Used this in ApiProtect
* Expand help message for &cascade a bit
Brion Vibber [Wed, 10 Dec 2008 22:31:32 +0000 (22:31 +0000)]
Follow-up to r44245, r44250 (comment field on Special:Import)
Label now clickable for comment field on the transwiki form as well as the upload form; gave them both distinctive IDs.
Brion Vibber [Wed, 10 Dec 2008 22:07:04 +0000 (22:07 +0000)]
Follow-up to r44216/r44217 "Followup to r44204. Hardcoding image because it should (in theory) work always and forever. If you have a wiki acting as repo and you've overridden the canonical name Image: it's your own fault."
It was noted that the existing code could fail for unusual article path settings including a suffix if only the 'articleUrl' was available. Pretty corner case, and probably breaks a lot of other things, but who knows. :)
Went ahead and refactored this a bit to handle the case and feel a little cleaner to me...
Dropped the private getDescBaseUrl() method since this seems a little easier to handle directly in getDescriptionUrl() now.
Brion Vibber [Wed, 10 Dec 2008 20:01:38 +0000 (20:01 +0000)]
Fix regression in Special:Ipblocklist caused by r43047 -- options arrays in show/hide links broken by being merged in the wrong order when moved from wfArrayMerge() to "+" operator.
Brion Vibber [Wed, 10 Dec 2008 19:41:20 +0000 (19:41 +0000)]
Revert r44119 "Remove extract() comment"
extract() is pretty much the devil and shouldn't ever be used for safe, legible code because it makes it much more difficult to analyse the code -- you have to run around trying to track down the source of local variables and there's generally a lot of pain.
Removing the FIXME comment isn't a substitute for fixing it. ;)
Brion Vibber [Wed, 10 Dec 2008 18:49:16 +0000 (18:49 +0000)]
add debug lines for UDP output so it can be more easily tested offline
Ilmari Karonen [Wed, 10 Dec 2008 18:41:28 +0000 (18:41 +0000)]
revert r44412 and part of r44406: keep the improved new page URLs, but use the old getInternalURL()/preg_replace() hack to generate them
Ilmari Karonen [Wed, 10 Dec 2008 17:03:57 +0000 (17:03 +0000)]
Seems r44406 would've broken the RC feed on secure.wikimedia org: fix by introducing a new config variable $wgRC2UDPScriptUrl (defaulting to $wgServer . $wgScript if not set).
NOTE: Wikimedia's secure.php needs to be updated to use the new variable. It might be possible to retire the fixupSquidUrl() hack once this is done, though I'm not sure if anything else relies on it.
Ilmari Karonen [Wed, 10 Dec 2008 15:56:02 +0000 (15:56 +0000)]
(bug 4253, bug 16586) Don't repeat titles of new pages in URLs in the RC->IRC feed, use the shorter and more useful revision ID instead.
Also simplify URL construction: old code used to call Title::getInternalURL() to build the URLs and then undo most of the work with preg_replace().
(TODO: Maybe consider introducing new global $wgIRCLineURLPrefix to optionally override the $wgInternalServer.$wgScript prefix?)
Aaron Schulz [Wed, 10 Dec 2008 15:30:46 +0000 (15:30 +0000)]
Init $parserCache only as needed
Siebrand Mazeland [Wed, 10 Dec 2008 14:19:51 +0000 (14:19 +0000)]
Localisation updates for core messages from Betawiki (2008-12-10 15:10 CET)
Roan Kattouw [Wed, 10 Dec 2008 14:12:54 +0000 (14:12 +0000)]
API: (bug 16581) Fix regression from r44015 ("Various minor cleanup") which changed Article::replaceSection() to treat $section=null as $section=0 rather than $section='' as it did before, causing a nasty API edit bug. When changing a function's behavior, please update the callers, and don't forget the API.
Alexandre Emsenhuber [Wed, 10 Dec 2008 11:42:35 +0000 (11:42 +0000)]
Fix for r44383: profiling error on unexisting class
David McCabe [Wed, 10 Dec 2008 06:40:05 +0000 (06:40 +0000)]
Revert r44386; depends on wfInvoke, also reverted.
David McCabe [Wed, 10 Dec 2008 06:02:14 +0000 (06:02 +0000)]
Refactored UserMailer.php. Please let me know if this breaks anything.
Aaron Schulz [Wed, 10 Dec 2008 05:33:57 +0000 (05:33 +0000)]
* Don't set ETag if $wgUseETag = false
* Avoid casting page ID as int twice
Aaron Schulz [Wed, 10 Dec 2008 05:12:54 +0000 (05:12 +0000)]
Reduce profile overhead here
Aaron Schulz [Wed, 10 Dec 2008 04:54:46 +0000 (04:54 +0000)]
Minor RawPage tweaks
Aaron Schulz [Wed, 10 Dec 2008 04:40:18 +0000 (04:40 +0000)]
Remove noisy profiling
Aaron Schulz [Wed, 10 Dec 2008 04:06:14 +0000 (04:06 +0000)]
Code style tweaks
Aaron Schulz [Wed, 10 Dec 2008 03:59:43 +0000 (03:59 +0000)]
Set $wgProfileToDatabase = false
Ilmari Karonen [Tue, 9 Dec 2008 23:20:44 +0000 (23:20 +0000)]
(bug 14365) skip invalid titles in RepoGroup::findFiles()
Aaron Schulz [Tue, 9 Dec 2008 23:00:28 +0000 (23:00 +0000)]
Whitespace/style consistency
Aaron Schulz [Tue, 9 Dec 2008 22:28:34 +0000 (22:28 +0000)]
Revert r44367; ends up with an extra fetch :/
Aaron Schulz [Tue, 9 Dec 2008 22:24:21 +0000 (22:24 +0000)]
Delay restriction fetching query
Aaron Schulz [Tue, 9 Dec 2008 22:12:29 +0000 (22:12 +0000)]
Cleanup updateRestrictions() some
Aaron Schulz [Tue, 9 Dec 2008 22:03:41 +0000 (22:03 +0000)]
Cleanup Title::getTouched()
Aaron Schulz [Tue, 9 Dec 2008 21:40:06 +0000 (21:40 +0000)]
Allow curid for filecache
Alexandre Emsenhuber [Tue, 9 Dec 2008 19:54:30 +0000 (19:54 +0000)]
fix doxygen warnings
Rotem Liss [Tue, 9 Dec 2008 16:04:48 +0000 (16:04 +0000)]
Localization update.
Raimond Spekking [Tue, 9 Dec 2008 15:21:07 +0000 (15:21 +0000)]
Per Brions suggestions mediawiki.org/wiki/Special:Code/MediaWiki/44245#c829
* Append the reason with a colon rather than wrapping in parens
* Rearrange the file-upload portion of the Special:Import form a bit
* Using one message for the comment field since it'll be identical in both parts of the form
More tweaks:
* Add labels for the transwiki import portion too
* Make the forms proper for RTL wikis
Andrew Garrett [Tue, 9 Dec 2008 15:00:17 +0000 (15:00 +0000)]
DB layer compatibility with MySQL 5+ - allow both >Exec_master_log_pos and ->Exec_Master_Log_Pos in SHOW SLAVE STATUS.
Aaron Schulz [Tue, 9 Dec 2008 11:51:00 +0000 (11:51 +0000)]
Tweak profile calls
Aaron Schulz [Tue, 9 Dec 2008 11:41:31 +0000 (11:41 +0000)]
Speed up filecache a tad
Siebrand Mazeland [Tue, 9 Dec 2008 07:42:23 +0000 (07:42 +0000)]
Localisation updates for core messages from Betawiki (2008-12-09 08:38 CET)
Aaron Schulz [Tue, 9 Dec 2008 03:25:02 +0000 (03:25 +0000)]
* Performance tweaks
* Whitespace
Aaron Schulz [Tue, 9 Dec 2008 02:55:49 +0000 (02:55 +0000)]
Tweak check order to be slightly better
Trevor Parscal [Tue, 9 Dec 2008 01:21:54 +0000 (01:21 +0000)]
Fixed empty list of footer links when no footer messages are set.
Brion Vibber [Tue, 9 Dec 2008 00:26:09 +0000 (00:26 +0000)]
* (bug 14268) SVG image sizes now extracted with proper XML parser
Uses a filter with XmlTypeCheck. Yay!
Now works with UTF-16 sample file uploaded on the bug. Should work with large comments etc as well.
Aryeh Gregor [Mon, 8 Dec 2008 23:10:24 +0000 (23:10 +0000)]
Fix MySQL-centrism in comment
Aaron Schulz [Mon, 8 Dec 2008 22:30:58 +0000 (22:30 +0000)]
Make pageCond() use PK is ID is already cached
Alexandre Emsenhuber [Mon, 8 Dec 2008 17:29:24 +0000 (17:29 +0000)]
* fix doxygen warnings
* fix whitespaces
Alexandre Emsenhuber [Mon, 8 Dec 2008 15:35:06 +0000 (15:35 +0000)]
Check if wfDebug() is defined before calling it since AutoLoader.php is loaded before GlobalFunctions.php and may result in fatal error
Aaron Schulz [Mon, 8 Dec 2008 11:48:08 +0000 (11:48 +0000)]
Tweak r44296: use autoloader if it is set there
Aaron Schulz [Mon, 8 Dec 2008 00:35:59 +0000 (00:35 +0000)]
*Skip autoloading of skin, always does inefficient strtolower() stuff and fails (returns false) anyway
*Add wfDebug() call on class load failure
Aaron Schulz [Mon, 8 Dec 2008 00:10:22 +0000 (00:10 +0000)]
*Minor cleanup
*Whitespace
Aaron Schulz [Sun, 7 Dec 2008 21:57:33 +0000 (21:57 +0000)]
Assign by ref to make sure cache fields carry over
Siebrand Mazeland [Sun, 7 Dec 2008 20:01:21 +0000 (20:01 +0000)]
Localisation updates for core messages from Betawiki (2008-12-07 20:57 CET)
Alexandre Emsenhuber [Sun, 7 Dec 2008 19:56:02 +0000 (19:56 +0000)]
Fix doxygen warnings
Siebrand Mazeland [Sat, 6 Dec 2008 23:59:44 +0000 (23:59 +0000)]
Localisation updates for core messages from Betawiki (2008-12-07 00:49 CET)
Alexandre Emsenhuber [Sat, 6 Dec 2008 21:16:55 +0000 (21:16 +0000)]
(bug 16577) When a blocked user tries to rollback a page, the block message is now only displayed once
Aaron Schulz [Sat, 6 Dec 2008 18:24:03 +0000 (18:24 +0000)]
Revert r44130,r44129 - breaks display of message
Aaron Schulz [Sat, 6 Dec 2008 18:00:17 +0000 (18:00 +0000)]
(bug 12998) Weaken DISPLAYTITLE restictions (patch by 'rememberthedot@gmail.com')
Andrew Garrett [Sat, 6 Dec 2008 00:32:12 +0000 (00:32 +0000)]
Fix up Configure extension logo setting handling:
* Replace annoying button with an onblur preview and server-side conversion of file names into URLs.
Chad Horohoe [Fri, 5 Dec 2008 20:22:43 +0000 (20:22 +0000)]
Bow out more gracefully if we can't write to the file. We've already got the foreign thumb URL on hand, so just use that.
Aaron Schulz [Fri, 5 Dec 2008 18:16:01 +0000 (18:16 +0000)]
Use boolean searching with '?' char
Chad Horohoe [Fri, 5 Dec 2008 17:25:22 +0000 (17:25 +0000)]
Cleanup to wfGetNull():
* Add override in case /dev/null isn't accessible (bug 11009)
* Use wfGetNull() in ProxyTools rather than hardcoding it
Aaron Schulz [Fri, 5 Dec 2008 17:10:35 +0000 (17:10 +0000)]
Keep form only for "file:" searches
Rotem Liss [Fri, 5 Dec 2008 16:13:56 +0000 (16:13 +0000)]
Localization update.
Aaron Schulz [Fri, 5 Dec 2008 14:37:58 +0000 (14:37 +0000)]
XHTML fix
Siebrand Mazeland [Fri, 5 Dec 2008 08:10:02 +0000 (08:10 +0000)]
Follow up on r44248:
* update messages.inc
* consistency update in message
Tim Starling [Fri, 5 Dec 2008 05:35:22 +0000 (05:35 +0000)]
New file upload content type checks using a simulation of IE's content type detection algorithm.
Siebrand Mazeland [Fri, 5 Dec 2008 02:29:52 +0000 (02:29 +0000)]
Follow up on r44245:
* update messages.inc
* rebuild MessagesEn.php
* copy 'filerevert-comment' to 'import-upload-comment', and 'import-comment'
Ariel Glenn [Fri, 5 Dec 2008 02:16:11 +0000 (02:16 +0000)]
handle xmlns for imports (bug #4520)
Ariel Glenn [Fri, 5 Dec 2008 02:14:11 +0000 (02:14 +0000)]
log comment for imports (bug #12728)
Chad Horohoe [Thu, 4 Dec 2008 21:21:48 +0000 (21:21 +0000)]
Actually make exists() useful here. Because of the order in which things are loaded, we've actually _already_ loaded the metadata prior to calling the constructor. It's safe to assume when making a new ForeignAPIFile that we'll want it to exist at that point. However, we'll default to false as it's safer to assume it doesn't exist and skip ourselves some Http requests. You should probably only be using newFromTitle() anyway :)
Chad Horohoe [Thu, 4 Dec 2008 18:23:52 +0000 (18:23 +0000)]
Same as before, hardcoding Image: is safer.
Roan Kattouw [Thu, 4 Dec 2008 15:59:26 +0000 (15:59 +0000)]
API: (bug 16541) Adding block expiry timestamp to list=logevents output (calculated from the block's timestamp and its duration)
Roan Kattouw [Thu, 4 Dec 2008 15:55:47 +0000 (15:55 +0000)]
Revert part of r44232, accidentally committed too much
Roan Kattouw [Thu, 4 Dec 2008 15:51:39 +0000 (15:51 +0000)]
API: (bug 16515) Added pst and onlypst parameters to action=parse, which do a pre-save transform on the input
Roan Kattouw [Thu, 4 Dec 2008 14:42:30 +0000 (14:42 +0000)]
API: Recommit r44182 (Added usprop=canemail to list=users) and rename canemail to emailable
Siebrand Mazeland [Thu, 4 Dec 2008 12:28:33 +0000 (12:28 +0000)]
Localisation updates from Betawiki. Namespaces and special page aliases
Siebrand Mazeland [Thu, 4 Dec 2008 11:28:44 +0000 (11:28 +0000)]
Add file namespaces for pt and pt-br to each other per request by 555.
Siebrand Mazeland [Thu, 4 Dec 2008 09:41:57 +0000 (09:41 +0000)]
Localisation updates for extension messages from Betawiki (2008-12-04 10:28 CET)